EnterpriseAI/ClosedCode
1
0
Fork 0
Code Issues Pull Requests Actions 29 Packages Projects Releases Wiki Activity

fix(app): unmount hidden session panes (#35628)

Browse Source
This commit is contained in:
Luke Parker
2026-07-09 09:44:02 +10:00
committed by GitHub
parent aa52d30d7f
commit d8a57ee15c
4 changed files with 291 additions and 311 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/e2e/regression/review-terminal-stacked.spec.ts
+3 -4
View File
@@ -168,8 +168,8 @@ test("keeps the review tree and terminal sized when both panels are open", async
await expectTree(page, 2_773, "action.yml")
await page.getByRole("button", { name: "Toggle file tree" }).click()
await expect(page.locator('[data-slot="session-review-v2-sidebar"]')).toHaveAttribute("aria-hidden", "true")
await expect(page.locator('#review-panel [data-component="file-tree-v2"]')).toHaveCount(1)
await expect(page.locator('[data-slot="session-review-v2-sidebar"]')).toHaveCount(0)
await expect(page.locator('#review-panel [data-component="file-tree-v2"]')).toHaveCount(0)
await page.getByRole("button", { name: "Toggle file tree" }).click()
await expectTree(page, 2_773, "action.yml")
@@ -181,8 +181,7 @@ test("keeps the review tree and terminal sized when both panels are open", async
await expectTree(page, 2_773, "action.yml")
await page.getByRole("button", { name: "Toggle review" }).click()
await expect(page.locator("#review-panel")).toHaveAttribute("aria-hidden", "true")
await expect(page.locator('#review-panel [data-component="file-tree-v2"]')).toHaveCount(1)
await expect(page.locator("#review-panel")).toHaveCount(0)
await page.getByRole("button", { name: "Toggle review" }).click()
await expectTree(page, 2_773, "action.yml")
await page.setViewportSize({ width: 1_000, height: 700 })