feat(session-ui): rewrite v2 prompt input (#37102)

This commit is contained in:
Brendan Allan
2026-07-17 18:02:19 +08:00
committed by GitHub
parent ed926be253
commit c0a258b22a
35 changed files with 3621 additions and 1095 deletions
@@ -0,0 +1,133 @@
import { describe, expect, test } from "bun:test"
import type { PromptInputV2PersistedState, PromptInputV2Suggestion } from "./types"
import { createPromptInputV2InteractionState, transitionPromptInputV2 } from "./machine"
const command: PromptInputV2Suggestion = {
id: "review",
kind: "command",
label: "/review",
}
function persisted(value = ""): PromptInputV2PersistedState {
return {
prompt: [{ type: "text", content: value, start: 0, end: value.length }],
cursor: value.length,
context: { items: [] },
}
}
describe("prompt input v2 interaction machine", () => {
test("opens inline commands only when slash is the entire prompt", () => {
const state = createPromptInputV2InteractionState()
const open = transitionPromptInputV2(state, { type: "input.changed", value: "/re" }, persisted())
const closed = transitionPromptInputV2(state, { type: "input.changed", value: "explain /re" }, persisted())
expect(open.state.popover).toEqual({ type: "command-inline", query: "re" })
expect(closed.state.popover).toEqual({ type: "closed" })
})
test("enters shell mode from an initial exclamation mark", () => {
const result = transitionPromptInputV2(
createPromptInputV2InteractionState(),
{ type: "input.changed", value: "!", persist: false },
persisted("!"),
)
expect(result.state.mode).toBe("shell")
expect(result.commands).toContainEqual({ type: "draft.setText", value: "" })
})
test("leaves shell mode with escape", () => {
const state = { ...createPromptInputV2InteractionState(), mode: "shell" as const }
const result = transitionPromptInputV2(
state,
{ type: "key.down", key: "Escape", ctrl: false, composing: false, ids: [] },
persisted(),
)
expect(result.state.mode).toBe("normal")
expect(result.handled).toBeTrue()
})
test("leaves shell mode with backspace when empty", () => {
const state = { ...createPromptInputV2InteractionState(), mode: "shell" as const }
const result = transitionPromptInputV2(
state,
{ type: "key.down", key: "Backspace", ctrl: false, composing: false, ids: [], empty: true },
persisted(),
)
expect(result.state.mode).toBe("normal")
expect(result.handled).toBeTrue()
})
test("closes a popover with ctrl-g before stopping a run", () => {
const state = {
...createPromptInputV2InteractionState(),
popover: { type: "context" as const, query: "", activeID: "first" },
}
const result = transitionPromptInputV2(
state,
{ type: "key.down", key: "g", ctrl: true, composing: false, ids: ["first"] },
persisted(),
)
expect(result.state.popover).toEqual({ type: "closed" })
expect(result.handled).toBeTrue()
})
test("opens the searchable command menu for a populated draft", () => {
const result = transitionPromptInputV2(
createPromptInputV2InteractionState(),
{ type: "commands.open" },
persisted("existing text"),
)
expect(result.state.popover).toEqual({ type: "command-menu", query: "" })
expect(result.state.focus).toBe("command-search")
})
test("prepends a menu command and preserves existing text as arguments", () => {
const open = transitionPromptInputV2(
createPromptInputV2InteractionState(),
{ type: "commands.open" },
persisted("existing text"),
)
const selected = transitionPromptInputV2(open.state, { type: "popover.select", item: command }, persisted("existing text"))
expect(selected.commands).toContainEqual({ type: "draft.setText", value: "/review existing text" })
expect(selected.state.popover).toEqual({ type: "closed" })
})
test("stores selected context files as prompt file parts", () => {
const item: PromptInputV2Suggestion = {
id: "src/index.ts",
kind: "file",
label: "index.ts",
path: "src/index.ts",
}
const state = {
...createPromptInputV2InteractionState(),
popover: { type: "context" as const, query: "index" },
}
const selected = transitionPromptInputV2(state, { type: "popover.select", item }, persisted("@index"))
expect(selected.commands).toContainEqual({ type: "mention.add", item })
})
test("loops active popover items with arrow keys", () => {
const state = {
...createPromptInputV2InteractionState(),
popover: { type: "context" as const, query: "", activeID: "second" },
}
const result = transitionPromptInputV2(
state,
{ type: "key.down", key: "ArrowDown", ctrl: false, composing: false, ids: ["first", "second"] },
persisted(),
)
expect(result.state.popover).toEqual({ type: "context", query: "", activeID: "first" })
expect(result.handled).toBeTrue()
})
})