refactor(tui): remove secondary action styles (#37378)

packages/tui/test/theme/v2/component.test.ts

@@ -1,5 +1,6 @@
 import { expect, test } from "bun:test"
 import { createSignal } from "solid-js"
+import { RGBA } from "@opentui/core"
 import { createComponentTheme } from "../../../src/theme/v2/component"
 import { DEFAULT_THEME } from "../../../src/theme/v2/defaults"
 import { resolveTheme } from "../../../src/theme/v2/resolve"
@@ -18,26 +19,34 @@ test("provides reactive property, variant, state, and context accessors", () =>
   expect(theme.hue.accent(500)).toBe(resolved().hue.accent[500])
   expect(theme.hue.interactive(500)).toBe(resolved().hue.interactive[500])
   expect(theme.hue.gray(200)).toBe(resolved().hue.gray[200])
+  expect(theme.increase(theme.background.surface.offset(), 1)).toBe(resolved().hue.neutral[300])
+  expect(theme.decrease(theme.hue.red(300), 2)).toBe(resolved().hue.red[100])
+  expect(theme.increase(theme.hue.red(900), 3)).toBe(resolved().hue.red[900])
+  expect(theme.decrease(theme.hue.red(100), 3)).toBe(resolved().hue.red[100])
+  const equivalent = RGBA.fromInts(...resolved().hue.green[500].toInts())
+  expect(theme.increase(equivalent, 1)).toBe(resolved().hue.green[600])
+  const unmatched = RGBA.fromInts(1, 2, 3)
+  expect(theme.increase(unmatched, 1)).toBe(unmatched)
   expect(theme.text.subdued()).toBe(resolved().text.subdued)
   expect(theme.text.action()).toBe(resolved().text.action.primary.default)
-  expect(theme.text.action.primary("pressed")).toBe(resolved().text.action.primary.pressed)
-  expect(theme.text.action.primary("selected")).toBe(resolved().text.action.primary.selected)
-  expect(theme.background.action.primary("selected")).toBe(resolved().background.action.primary.selected)
-  expect(theme.background.action.primary({ selected: true })).toBe(resolved().background.action.primary.selected)
-  expect(theme.background.action.primary({ focused: true, selected: true })).toBe(
+  expect(theme.text.action("pressed")).toBe(resolved().text.action.primary.pressed)
+  expect(theme.text.action("selected")).toBe(resolved().text.action.primary.selected)
+  expect(theme.background.action("selected")).toBe(resolved().background.action.primary.selected)
+  expect(theme.background.action({ selected: true })).toBe(resolved().background.action.primary.selected)
+  expect(theme.background.action({ focused: true, selected: true })).toBe(
     resolved().background.action.primary.focused,
   )
-  expect(theme.background.action.primary({ pressed: true, focused: true, selected: true })).toBe(
+  expect(theme.background.action({ pressed: true, focused: true, selected: true })).toBe(
     resolved().background.action.primary.pressed,
   )
-  expect(theme.background.action.primary({ disabled: true, pressed: true, focused: true, selected: true })).toBe(
+  expect(theme.background.action({ disabled: true, pressed: true, focused: true, selected: true })).toBe(
     resolved().background.action.primary.disabled,
   )
-  expect(theme.background.action.primary({ disabled: false, selected: false })).toBe(
+  expect(theme.background.action({ disabled: false, selected: false })).toBe(
     resolved().background.action.primary.default,
   )
-  expect(theme.background.action.secondary("disabled")).toBe(
-    resolved().background.action.secondary.disabled,
+  expect(theme.background.action.destructive("disabled")).toBe(
+    resolved().background.action.destructive.disabled,
   )
   expect(theme.background.surface.offset()).toBe(resolved().background.surface.offset)
   expect(theme.background.surface.overlay()).toBe(resolved().background.surface.overlay)
@@ -46,7 +55,7 @@ test("provides reactive property, variant, state, and context accessors", () =>
 
   setContext("@context:elevated")
   expect(theme.text()).toBe(resolved().contexts["@context:elevated"]!.text.default)
-  expect(theme.background.action.primary("focused")).toBe(
+  expect(theme.background.action("focused")).toBe(
     resolved().contexts["@context:elevated"]!.background.action.primary.focused,
   )
   expect(theme.background.formfield("selected")).toBe(

packages/tui/test/theme/v2/resolve.test.ts

@@ -142,7 +142,6 @@ test("resolves matched action variants and states", () => {
   expect(theme.text.action.primary.selected).toBeInstanceOf(RGBA)
   expect(theme.background.action.primary.pressed).toBeInstanceOf(RGBA)
   expect(theme.background.action.primary.selected).toBeInstanceOf(RGBA)
-  expect(theme.text.action.secondary.default).toBeInstanceOf(RGBA)
   expect(theme.background.action.destructive.disabled).toBeInstanceOf(RGBA)
 })
 
@@ -175,7 +174,6 @@ test("context overrides rewire semantic references and apply state precedence",
       default: "#111111",
       action: {
         primary: { default: "$text.default", $pressed: "#222222" },
-        secondary: { default: "$text.default" },
       },
     },
     "@context:elevated": {
@@ -189,7 +187,6 @@ test("context overrides rewire semantic references and apply state precedence",
   const overlay = theme.contexts["@context:elevated"]!
 
   expect(overlay.text.default.toInts()).toEqual([51, 51, 51, 255])
-  expect(overlay.text.action.secondary.default.toInts()).toEqual([51, 51, 51, 255])
   expect(overlay.text.action.primary.pressed.toInts()).toEqual([68, 68, 68, 255])
   expect(overlay.text.action.primary.focused.toInts()).toEqual([85, 85, 85, 255])
 })

packages/tui/test/theme/v2/types.test.ts

@@ -6,7 +6,6 @@ const text = {
   subdued: "$hue.neutral.600",
   action: {
     primary: { default: "$hue.neutral.100", $pressed: "$hue.neutral.200" },
-    secondary: { default: "$hue.neutral.900" },
     destructive: { default: "$hue.red.100", $disabled: "$hue.neutral.500" },
   },
   formfield: { default: "$hue.neutral.600", $selected: "$hue.neutral.100" },
@@ -24,7 +23,6 @@ const background = {
       $pressed: "$hue.interactive.800",
       $selected: "$hue.interactive.700",
     },
-    secondary: { default: "$hue.neutral.200" },
     destructive: { default: "$hue.red.600" },
   },
   formfield: { default: "$hue.neutral.100", $selected: "$hue.interactive.600" },

packages/tui/test/theme/v2/v1-migrate.test.ts

@@ -30,7 +30,6 @@ test("migrates resolved V1 modes into literal V2 tokens", () => {
   expect(migrated.light.scrollbar?.default).toBe(hex(legacy.borderActive))
   expect(migrated.light.diff?.lineNumber?.background?.removed).toBe(hex(legacy.diffRemovedLineNumberBg))
   expect(migrated.light.markdown?.emphasis).toBe(hex(legacy.markdownEmph))
-  expect(resolved.background.action.secondary.focused.toInts()).toEqual(legacy.backgroundElement.toInts())
   expect(resolved.background.surface.offset.toInts()).toEqual(legacy.backgroundPanel.toInts())
   expect(resolved.background.surface.overlay.toInts()).toEqual(legacy.backgroundMenu.toInts())
   expect(resolved.background.formfield.selected.toInts()).toEqual(legacy.background.toInts())
@@ -46,9 +45,6 @@ test("migrates resolved V1 modes into literal V2 tokens", () => {
   expect(resolved.contexts["@context:elevated"]?.background.default.toInts()).toEqual(
     legacy.backgroundPanel.toInts(),
   )
-  expect(resolved.contexts["@context:elevated"]?.background.action.secondary.default.toInts()).toEqual(
-    legacy.backgroundPanel.toInts(),
-  )
   expect(resolved.contexts["@context:elevated"]?.background.action.primary.default.toInts()).toEqual([0, 0, 0, 0])
   expect(resolved.contexts["@context:elevated"]?.text.action.primary.default.toInts()).toEqual(
     legacy.text.toInts(),